fix: prevent panic in retryDelay when delay overflows or is negative #519
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a panic in
retryDelay
that occurs when the computeddelay
becomes negative due to integer overflow intime.Duration
for largeretryCount
valuesProblem
0.5 * 2^retryCount * time.Second
) can exceed the maximumint64
fortime.Duration
, wrapping around to negative values.retryCount = 35
, where the computeddelay
wrapped to-9223372036854775808
.delay
is negative, the subsequentrand.Int63n(delay/4)
call panics.Fix
delay
to a safe range[1s, maxDelay]
before applying jitter.rand.Int63n
is always >= 1 second, preventing it from receiving invalid (<=0) arguments.Impact