Skip to content

Update RealtimeConversationClient.cs #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BlinkSun
Copy link

@BlinkSun BlinkSun commented Feb 7, 2025

uriBuilder already concat the ? into the uri;
that make double ?? and cause problem;

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
uriBuilder already concat the ? into the uri;
that make double ?? and cause problem;
@BlinkSun
Copy link
Author

BlinkSun commented Feb 7, 2025

image

image

@joseharriaga
Copy link
Collaborator

Thank for your contribution, @BlinkSun ! Question: What version of .NET are you using?

@joseharriaga joseharriaga self-assigned this Feb 19, 2025
@BlinkSun
Copy link
Author

BlinkSun commented Feb 19, 2025

I am using your library in an application that we continue to maintain on .NET Framework 4.8, and so far, it has been working well thanks to .NET Standard compatibility. I created this PR by forking your repository, and I tested my fix with my .NET Framework 4.8 application—it works perfectly.

https://learn.microsoft.com/en-us/dotnet/api/system.uribuilder.query?view=netframework-4.8#remarks

Let me know if you need further clarification!

@BlinkSun
Copy link
Author

BlinkSun commented Mar 28, 2025

Hey @joseharriaga whats happen with that fix ? I need to recompile manually with my fix the lib to use it in my framework 4.8 app 😢

@joseharriaga
Copy link
Collaborator

@trrwilson : I recall you mentioned that there are currently limitations in the RealtimeConversationClient related to .NET Framework. Could you provide more information and how it relates to this issue?

@BlinkSun
Copy link
Author

The fix work but if you want to stay in your codeline, you can fix it by using your ClientUriBuilder class that you use everywhere !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants