Align FailSafeQA compliance with benchmark threshold - #3014
Align FailSafeQA compliance with benchmark threshold#3014sylvesterkaczmarek wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e29ecdc263
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| max_retries: int = 3, | ||
| backoff: float = 1.0, | ||
| compliance_threshold: int = 6, | ||
| compliance_threshold: int = 4, |
There was a problem hiding this comment.
Align the notebook with the new default threshold
When readers execute the FailSafeQA notebook, its calls to run_failsafeqa omit compliance_threshold, so they now calculate compliance and the derived robustness/grounding metrics at ≥4. However, the following summary cell still defaults to and explicitly passes 6, its saved output reports “Compliance threshold: ≥ 6,” and the narrative interprets the metrics as perfect 6/6 scores. Rerunning the notebook therefore produces CSVs under one metric while the published table and explanation report another; update the threshold-dependent notebook cells, outputs, and bundled results alongside this default, or explicitly retain 6 for those calls.
Useful? React with 👍 / 👎.
Summary
Motivation
FailSafeQA uses a 1–6 judge rubric where scores 4, 5, and 6 are compliant. The script's own comment already says
rating >= 4should be treated as compliant, butCOMPLIANCE_THRESHOLDand all callable defaults are currently set to6.That means the default evaluator only counts perfect score-6 answers as compliant and marks valid score-4/5 answers non-compliant, changing the benchmark definition and depressing the reported robustness/grounding metrics.
The defaults should match the benchmark boundary already documented by the rubric.
Validation
compliance_threshold=overrides remain unchangedSelf-review
6->4replacements in one file.Maintainers may modify the branch if needed.