Exclude git metadata from deployment images - #3005
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitto the Deployment Manager's generated.dockerignore.Motivation
The generated Dockerfile uses
COPY . ., while the generated.dockerignorecurrently excludes virtual environments,.env, data, uploads, and other local state but not the project's.gitdirectory.For a Git-backed project, that sends repository history and metadata into the Docker build context and can copy it into the image. Besides unnecessary build context and image size, this can expose commit history, branch metadata, and configured repository remotes inside the built container.
The generated ignore file should exclude
.gitby default. Existing user-supplied.dockerignorefiles are not overwritten by this helper.Validation
This is a single added ignore entry:
.dockerignorenow excludes.git.dockerignorefiles remain untouchedSelf-review
.gitignore fix and found none.Maintainers may modify the branch if needed.