Validate LLM judge concurrency - #2995
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrencyvalues at thejudge_folder()boundary.Motivation
judge_folder()acceptsconcurrencydirectly and later passes it toThreadPoolExecutor(max_workers=concurrency). Values such as0or-1are therefore accepted by the function and CLI, perform some setup work, and then fail with an executor-internalValueError.This parameter is part of the evaluator's public helper/CLI surface, so invalid worker counts should fail immediately with a clear, local validation error before creating output directories, loading prompts, or constructing the client.
Validation
The new guard enforces the executor's existing requirement explicitly:
concurrency < 1->ValueError("concurrency must be at least 1")concurrency >= 1-> existing behavior unchangedNo API requests, judge prompts, retry behavior, or result formats are changed.
Self-review
Maintainers may modify the branch if needed.