fix: invalid model setting when passing prompt to Agent #1852
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm-openai
approved these changes
Oct 14, 2025
| conversation=self._non_null_or_not_given(conversation_id), | ||
| instructions=self._non_null_or_not_given(system_instructions), | ||
| model=self.model, | ||
| model=self.model if prompt is None else NOT_GIVEN, |
There was a problem hiding this comment.
can you add a comment here explaining why?
rm-openai
reviewed
Oct 14, 2025
|
@rm-openai good point; actually it's feasible. so, when a developer explicitly pass a model, it should be allowed. the default model still needs to be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the bug reported for TS SDK, which exists for Python too.