Document AdvancedSQLiteSession and refactor session docs
#1791
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # `AdvancedSQLiteSession` | ||
|
|
||
| ::: agents.extensions.memory.advanced_sqlite_session.AdvancedSQLiteSession |
There was a problem hiding this comment.
[P1] Remove reference to nonexistent AdvancedSQLiteSession module
The new API reference page renders agents.extensions.memory.advanced_sqlite_session.AdvancedSQLiteSession, but there is no corresponding module anywhere under agents.extensions.memory (the package only contains encrypt_session.py and sqlalchemy_session.py). MkDocStrings will raise a ModuleNotFoundError and the page cannot build, and the documentation links to a class that is not implemented. Either implement the class or drop the reference so the docs build successfully.
Useful? React with 👍 / 👎.
|
CI failing as AdvancedSQLiteSession is not yet merged. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
habema
changed the title
AdvancedSQLiteSession and refactor session docsAdvancedSQLiteSession and refactor session docs
|
@seratch this is ready to be merged |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| - ドキュメント: | ||
| - agents.md | ||
| - running_agents.md | ||
| - sessions.md | ||
| - Sessions: | ||
| - sessions/index.md | ||
| - sessions/sqlalchemy_session.md | ||
| - sessions/encrypted_session.md | ||
| - sessions/advanced_sqlite_session.md |
There was a problem hiding this comment.
The navigation for the Japanese locale now references sessions/index.md, sessions/sqlalchemy_session.md, sessions/encrypted_session.md, and sessions/advanced_sqlite_session.md, but only docs/ja/sessions.md exists. Building the docs with the ja locale (or browsing the generated site) will fail because those files are missing. Either restore the original sessions.md entry or add the corresponding translated files before merging.
Useful? React with 👍 / 👎.
EnryptedSession