fix(paperbench): preserve solver shortnames in metrics parsing - #174
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
fix(paperbench): preserve solver shortnames in metrics parsing#174sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve complete PaperBench solver shortnames when reconstructing agent IDs from run-group records.
PaperBench creates run-group IDs as:
but
parse_run_data()currently derives the agent ID with:That truncates any solver shortname containing underscores. The built-in direct-submission solver reports
direct_submission_solver, so its records are currently grouped under the incorrect agent IDsolver.Fix
Parse the generated
_run-group_delimiter and preserve the full suffix as the solver/agent identifier. For records that do not contain that delimiter, retain the previous final-underscore-token fallback for compatibility with older/custom run-group IDs.Regression coverage
Added a JSONL-level regression using the built-in
direct_submission_solvernaming shape and verified thatparse_run_data()returns the fulldirect_submission_solverkey and retains the corresponding paper run.Risk
Low. Standard run groups now preserve exactly the shortname used when they were created. Legacy/custom IDs without the
_run-group_delimiter keep the previous parsing behavior.Issue number
N/A. Found while auditing PaperBench metrics attribution.