fix(paperbench): handle uneven seed counts in run parsing - #173
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
fix(paperbench): handle uneven seed counts in run parsing#173sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make PaperBench run reconstruction handle papers with uneven numbers of recorded seeds without raising
IndexError.parse_run_data()builds seed-indexedEvaluationRunobjects up to the largest per-paper seed count. For a paper with fewer runs, the loop currently skips only when:If another paper has two or more additional seeds, a later iteration reaches
seed > len(data)and still evaluatesdata[seed], crashing the metrics parser.Fix
Treat every out-of-range seed as unavailable:
This preserves the intended behavior described by the surrounding comment: incomplete evaluation runs are retained with only the paper evaluations that exist for that seed.
Regression coverage
Added a JSONL-level regression with one paper containing three recorded runs and another containing one. The test verifies that parsing produces three evaluation runs, with the shorter paper present only in the first run, instead of crashing on the third seed.
Risk
Low. Equal-length run sets are unchanged. The only behavior change is for uneven per-paper seed counts that would otherwise index past the end of a paper's data.
Issue number
N/A. Found while auditing PaperBench metrics reconstruction.