Make nanoeval global concurrency check atomic - #171
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BEGIN EXCLUSIVE_maybe_pull_task_from_queue()currently checksnum_running < max_concurrencybefore starting its exclusive transaction. With multiple workers, two workers can therefore observe the same available global slot, then serialize through the transaction and each claim a task. The resulting number of running tasks can exceed the configured global concurrency limit.This change starts
BEGIN EXCLUSIVEbefore reading the running-task count and keeps the limit check and task claim in one transaction. That makes the check-and-claim operation atomic across workers while preserving the existing per-eval concurrency query and task-selection behavior.