Skip to content

Fix SWE-Lancer default runs directory - #170

Open
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix-swelancer-default-runs-dir
Open

Fix SWE-Lancer default runs directory#170
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix-swelancer-default-runs-dir

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary

  • make SWE-Lancer's default runs directory use the existing project-root helper
  • avoid constructing a relative path from the module name string
  • add regression coverage that requires the default runs path to match the canonical absolute project runs directory

get_default_runs_dir() currently calls Path(__name__).parent / "runs". Since __name__ is a module name such as swelancer.utils.custom_logging, this produces a relative path like swelancer.utils/runs rather than the project's actual runs/ directory.

The same helper is used as the default value for SWELancerEval.runs_dir, so this can place run output and fallback log output in an unintended working-directory-relative location.

This change delegates to the existing swelancer.utils.general.get_runs_dir() helper, which resolves the project root and returns the canonical absolute runs directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant