Propagate external cancellation from EVMbench agent runs - #167
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Propagate external cancellation from EVMbench agent runs#167sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.CancelledErrorto propagate through EVMbench agent executionreturnfromfinallyexecute_agent_in_computer()currently catchesasyncio.CancelledError, even thoughasyncio.timeout()also uses cancellation internally. More importantly,run_agent_in_computer()returnsAgentOutputfrom itsfinallyblock. Areturninfinallysuppresses an in-flight external cancellation, so shutting down or cancelling the evaluation can be converted into an apparently normal agent run and grading can continue.The fix handles the timeout as
asyncio.TimeoutErroroutside the timeout context, leaves external cancellation uncaught, and returnsAgentOutputonly after normal completion of the wrapper.Regression coverage verifies that an ordinary agent timeout remains locally handled while externally cancelling the running task raises
CancelledErrorto the caller.