Limit PaperBench computer retries to startup - #166
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_computer_with_retry()currently yields the computer from inside Tenacity'swith attempt:block. That means an exception raised by the caller'sasync withbody is fed back into the retry attempt. If it matchesexception_types, the helper can retry even though startup succeeded, causing the async context manager to try to yield again.The fix uses an
AsyncExitStackto retain the successfully entered runtime context, completes the retry loop first, and yields the computer only after startup has succeeded.Regression coverage verifies that genuine startup failures are retried while a matching exception from the caller body propagates after exactly one computer start.