Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/paperbench/paperbench/rubric/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def get_prior_nodes(self, root: TaskNode, max_prior_nodes: int | None = None) ->

required_nodes = required_nodes[:-1] # Don't include the target node
if max_prior_nodes is not None:
required_nodes = required_nodes[-max_prior_nodes:]
required_nodes = required_nodes[-max_prior_nodes:] if max_prior_nodes > 0 else []
return required_nodes

def get_descendants_depth_first(self) -> list[Self]:
Expand Down
33 changes: 33 additions & 0 deletions project/paperbench/tests/unit/test_rubric_prior_nodes.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
from paperbench.rubric.tasks import TaskNode


def _rubric() -> tuple[TaskNode, TaskNode]:
b = TaskNode(
id="B",
requirements="B",
weight=1,
task_category="Code Development",
)
f = TaskNode(
id="F",
requirements="F",
weight=1,
task_category="Code Development",
)
g = TaskNode(
id="G",
requirements="G",
weight=1,
task_category="Code Development",
)
c = TaskNode(id="C", requirements="C", weight=1, sub_tasks=[f, g])
root = TaskNode(id="A", requirements="A", weight=1, sub_tasks=[b, c])
return root, g


def test_get_prior_nodes_respects_zero_limit() -> None:
root, target = _rubric()

assert [node.id for node in target.get_prior_nodes(root)] == ["A", "B", "C", "F"]
assert target.get_prior_nodes(root, max_prior_nodes=0) == []
assert [node.id for node in target.get_prior_nodes(root, max_prior_nodes=2)] == ["C", "F"]