Preserve nanoeval max concurrency when resuming run sets - #163
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Preserve nanoeval max concurrency when resuming run sets#163sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_concurrencywhen the database is reopenedrun_set_idmetadata behavior unchangedopen_run_set_db()currently upsertsmax_concurrencywithON CONFLICT ... DO UPDATE, resetting it to1_000_000every time an existing run-set database is opened.This conflicts directly with
nanoeval.bin.concurrency, which stores a user-selected limit in the same metadata key. Reopening or resuming the run set therefore silently discards that value before workers read it, and even the concurrency command itself resets the previous value as part of opening the database.The fix changes initialization to
ON CONFLICT DO NOTHING, so new databases still receive the default while existing run sets retain their configured limit.Regression coverage sets a custom limit, closes the run set, reopens the same run-set ID, and verifies the value is preserved.