Group binary agent outcomes for standard metrics - #162
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_summary_error_aware()only has a binary result for each rollout: correct or incorrect._compute_metrics_plus_outcome_aggregations()currently assignsanswer_group_idwithgroupby(...).cumcount(), so every attempt is treated as a different answer even when multiple attempts have the same outcome.That does not affect the repository's minimal accuracy-only backend, but it breaks the answer-group contract for richer standard metric backends that use group identity for consensus-style metrics. Two correct attempts should belong to the same answer group, as should two incorrect attempts.
The fix uses
1for correct and0for incorrect, and keeps one correctness row per(instance, answer_group_id)so repeated outcomes do not duplicate the correctness mapping.Regression coverage verifies that repeated correct attempts share one group while incorrect attempts use the other group.