Load legacy PaperBench reproduction metadata with optional defaults - #143
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Load legacy PaperBench reproduction metadata with optional defaults#143sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep cached PaperBench reproduction metadata loadable when it was written before newer optional fields were added.
ReproductionMetadataalready declaresretried_resultswith an empty-list default and three fields as optional, butfrom_dict()indexes all four keys directly. Reusing an older*_executed_metadata.jsoncan therefore raiseValueErroreven though the dataclass has well-defined defaults for the missing fields.Fixes #142.
Fix
retried_resultsto[];repro_execution_time,git_status_after_reproduce, andexecuted_submissionwithdict.get();Regression coverage
Adds tests verifying that:
Serialization output and the required core metadata schema are unchanged.