Handle uneven PaperBench seed counts when parsing runs - #141
Closed
sylvesterkaczmarek wants to merge 2 commits into
Closed
Handle uneven PaperBench seed counts when parsing runs#141sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
parse_run_data()to build incomplete PaperBench evaluation runs when papers have uneven numbers of available seeds instead of indexing past shorter histories.The parser computes the maximum seed count across papers, but its short-paper guard currently skips only when
seed == len(data). If one paper has one run and another has three, seed 2 satisfies2 != 1and the code attemptsdata[2], raisingIndexError.Fixes #140.
Fix
Skip whenever
seed >= len(data).Regression coverage
Adds a unit regression with one paper containing one run and another containing three runs. It verifies parsing produces three
EvaluationRunobjects, with the shorter paper present only in the first run and no out-of-range access.Timestamp ordering, recent-seed selection, disqualification handling, and complete-run filtering are unchanged.