You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The approach here — forwarding model/effort into the review/start RPC params — doesn't actually make the flags work. Probing the real app-server (codex-cli 0.144.1), review/start accepts model/effort without error but the Rust side drops unknown fields (serde, no deny_unknown_fields), and ReviewStartParams has no model/effort field in the first place (TS2353 on a direct type-probe). The model field is inert on the server across thread/start/turn/start/review/start — the effective override is -c model="…" at spawn time (#408), not an RPC field.
For effort: adversarial-review can be fixed via turn/start (its params include effort) per #476; native review has no effort field in the protocol, so it's not fixable on the plugin side without the #408-style spawn override.
Left detailed notes + the server-probe evidence on #476 and #408. Folding into those instead of keeping a separate incompatible change open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate
--modeland--effortto/codex:reviewand/codex:adversarial-review, matching the existingtaskbehavior.Validation:
node --test tests/commands.test.mjsnode --test tests/runtime.test.mjs