Run "test" workflow without startup errors. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
I noticed after the merge of my last PR that none of the tests ran, so I pulled the error:
It didn't make much sense, so I tested removing the
matrix.osand hardcodingubuntu-latestwhich immediatly fired up the massive matrix of tests. However, the include/exclude were using caret notation while matrix using asterisk notation which caused some oddities.I went to the EOL website and saw Symfony 6.3 was EOL, so removed it to make my life a bit easier. I then excluded any combination that failed.
This proved that PHP 8.4 isn't really working well, but I imagine thats because it needs a more modern Symfony version. I'm no Symfony dev, so I figured I'd throw this PR up to have a passing test suite and someone else could take a stab at modernizing supported versions.
(squash merge please if you go forward w/ this - a bit messy commit history)