Add Base Uri to Config #55
Closed
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydar
reviewed
Jul 19, 2023
|
|
||
| if (! is_string($apiKey) || ($organization !== null && ! is_string($organization))) { | ||
| if (! is_string($apiKey) || ! is_string($baseUri) || ($organization !== null && ! is_string($organization))) { |
There was a problem hiding this comment.
Just a exception for all cases? Maybe we can reconsider this..
There was a problem hiding this comment.
Without this condition ! is_string($baseUri) it cannot pass phpstan. Do you have better solution?
There was a problem hiding this comment.
I didn't mean remove !is_string condition. Instead of this, you can use different if block and exception for baseUrl
|
Closing in favour of #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime we need to change Base Uri also. Example: https://learn.microsoft.com/en-us/azure/ai-services/openai/reference