Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving laravel framework to require-dev #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mevtho
Copy link

@mevtho mevtho commented Jul 17, 2024

Related to discussions

#40
#34

I had the a similar issue when trying to add the package to a laravel-zero application (conflict with Illuminate packages).

Moving to require-dev should allow the same development experience while not forcing a full install of the laravel framework when adding to a laravel-zero project.

Copy link
Collaborator

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is the right fix. Including full Laravel was probably a mistake, but I see 4 occurrences of Illuminate.

use Illuminate\Console\Command;
use Illuminate\Contracts\Support\DeferrableProvider;
use Illuminate\Support\ServiceProvider as BaseServiceProvider;
use Illuminate\Support\Facades\Facade;

So we could probably isolate down to Console, Contracts and Support.

Console could probably be dev, as its only used in the install command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants