Repair virt_query outputter #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code was not functional. Only return if a dictionary is passed and reference the correct data. Signed-off-by: Georg Pfuetzenreuter <[email protected]> (cherry picked from commit e3c365ad8f385121aa878950e13892d986d79656)
Disk data in Libvirt VMs does not contain a disk size if the disk references a block device. Skip the field for such disks instead of failing with a key error. Signed-off-by: Georg Pfuetzenreuter <[email protected]> (cherry picked from commit ed73abd44117ad745e9c91f2b33caf04402b117c)
|
Thanks for this contribution @tacerus. I just added here a unit test file for |
meaksh
approved these changes
Feb 21, 2025
|
Thanks for adding a test @meaksh, I'll suggest it upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR
saltstack/salt#65843
What does this PR do?
What issues does this PR fix or reference?
Fixes: saltstack/salt#65841
Previous Behavior
Outputter returns traceback.
New Behavior
Outputter returns pretty output:
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
^ I'm not sure about tests for this, some other outputters have tests in
tests/pytests/unit/output/, but I'm not sure it's feasible for this one, it would need to hook into thevirtmodule tests somehow to generate a VM fixture?Commits signed with GPG?
Yes