Skip to content

SPECS: Add lazygit Go dependencies - #751

Open
cl2t wants to merge 42 commits into
openRuyi-Project:mainfrom
cl2t:lazygit-deps-1
Open

SPECS: Add lazygit Go dependencies#751
cl2t wants to merge 42 commits into
openRuyi-Project:mainfrom
cl2t:lazygit-deps-1

Conversation

@cl2t

@cl2t cl2t commented Jun 21, 2026

Copy link
Copy Markdown

Summary

Add the remaining lazygit Go dependency packages that are not yet in main,
and update the existing go-github-charmbracelet-x package so its bundled
x/ansi, x/cellbuf, and x/term sources export usable providers.

This revision rebases onto current main and drops 13 source packages that
landed independently while the PR was open, so this branch no longer overwrites
existing specs:

  • go-github-gookit-assert, go-github-gookit-color
  • go-github-h2non-parth, go-github-henvic-httpretty
  • go-github-huandu-xstrings, go-github-invopop-jsonschema
  • go-github-masterminds-goutils, go-github-mgutz-ansi
  • go-github-nbio-st, go-github-samber-lo
  • go-github-sanity-io-litter, go-github-shopspring-decimal
  • go-github-urfave-cli

Reviewer-driven and follow-up changes retained in this revision:

  • keep the complete github.com/cli/go-gh/v2 v2.13.0 module
  • package the supported chroma and gojq commands with reusable noarch Go
    source subpackages
  • place every explicit %prep section after %description
  • name gopkg.in packages with a hyphenated -vN suffix, as requested in
    review (go-gopkg-fsnotify-v1, go-gopkg-ozeidan-fuzzy-patricia-v3,
    go-gopkg-h2non-gock-v1); the go(...) providers still use the upstream
    import paths
  • compile complete test suites; skip only the gojq CLI golden case
    TestCliRun/stream_option_with_unterminated_input, whose expected
    encoding/json error text (unexpected EOF) no longer matches distro Go
    (unexpected end of JSON input)

go-github-gdamore-tcell-v3 and lazygit itself remain outside this PR. Their
packaging is still blocked by the repository's older
clipperhouse/uax29/v2 provider versus the API required by tcell/v3.

Related Issue

  • N/A

Validation

  • pre-commit passes for all 42 touched spec files
  • git diff --name-status origin/main...HEAD shows 41 added specs and one
    modification (go-github-charmbracelet-x)
  • pure-main OBS project home:cl_2:pr751-rebase-puremain succeeds for all 42
    source packages on both x86_64 and riscv64
  • chroma and gojq each produce an architecture-specific command RPM and a
    noarch Go source subpackage
  • the built go-github-charmbracelet-x RPM exports:
    • go(github.com/charmbracelet/x/ansi) = 0.11.6
    • go(github.com/charmbracelet/x/cellbuf) = 0.0.15
    • go(github.com/charmbracelet/x/term) = 0.2.2
  • the complete go-gh RPM exports
    go(github.com/cli/go-gh/v2) = 2.13.0
  • all 42 branch commits contain DCO sign-offs, touch one source package each,
    and contain no AI co-author trailers

Checklist

Assisted-by: Claude Code:Opus 4.8
Assisted-by: Claude Code:GPT-5.6 Sol
Assisted-by: Grok:Grok 4.6

@openruyi-bot openruyi-bot Bot added AI Assistance AI is used to help with portions of code, tests, or documentation. Community: Student contribution Used by contributors that are currently students at an educational institution. BuildSystem: golangmodule Issue/PR related to golangmodule BuildSystem. Target: Rolling Targeting rolling/current branch. Workflow: Ready For Review Ready for review by anyone with domain expertise. labels Jun 21, 2026
@cl2t cl2t changed the title SPECS: Add lazygit Go dependencies (batch 1) SPECS: Add lazygit Go dependencies Jun 21, 2026
@cl2t
cl2t force-pushed the lazygit-deps-1 branch from a6d1a76 to 384bd14 Compare June 21, 2026 05:33
@cl2t
cl2t force-pushed the lazygit-deps-1 branch from 384bd14 to 7023a4b Compare July 20, 2026 16:35
@openruyi-bot openruyi-bot Bot added the BuildSystem: golang Issue/PR related to golang BuildSystem. label Jul 20, 2026
@cl2t
cl2t force-pushed the lazygit-deps-1 branch from 7023a4b to 0e053dc Compare July 21, 2026 05:51

@misaka00251 misaka00251 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%prep should be under %description in any circumstances.

Name: go-github-gookit-assert
Version: 0.1.1
Release: %autorelease
Summary: Provides some of the commonly used tool functions for assertions in Go unit tests. 提供了一些常用的 Go 单元测试中用于断言的工具函数等,没有外部依赖

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the Chinese characters.

Name: go-github-gookit-color
Version: 1.6.1
Release: %autorelease
Summary: 🎨 Terminal color rendering library, support 8/16 colors, 256 colors, RGB color rendering output, support Print/Sprintf methods, compatible with Windows. GO CLI 控制台颜色渲染工具库,支持16色,256色,RGB色彩渲染输出,使用类似于 Print/Sprintf,兼容并支持 Windows 环境的色彩渲染

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the Chinese characters.

Name: go-github-integrii-flaggy
Version: 1.8.0
Release: %autorelease
Summary: Idiomatic Go input parsing with subcommands, positional values, and flags at any position. No required project or package layout and no external dependencies.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Summary: Idiomatic Go input parsing with subcommands, positional values, and flags at any position. No required project or package layout and no external dependencies.
Summary: Idiomatic Go input parsing with subcommands, positional values, and flags at any position.

%define _name fsnotify.v1
%define go_import_path gopkg.in/fsnotify.v1

Name: go-gopkg-fsnotify.v1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be go-gopkg-fsnotify-v1?

%define _name fuzzy-patricia.v3
%define go_import_path gopkg.in/ozeidan/fuzzy-patricia.v3

Name: go-gopkg-ozeidan-fuzzy-patricia.v3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be go-gopkg-ozeidan-fuzzy-patricia-v3?

Comment thread SPECS/humanlog/humanlog.spec Outdated
humanlog reads structured log streams in JSON or logfmt format from standard
input and renders them as human-friendly, colorized output.

%package -n go-github-aybabtme-humanlog

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with the rest of the spec file.

@openruyi-bot openruyi-bot Bot added Workflow: In Review Issues that are undergoing code review and/or undergoing design review. and removed Workflow: Ready For Review Ready for review by anyone with domain expertise. labels Jul 21, 2026
cl2t added 3 commits September 3, 2026 12:17
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
@cl2t
cl2t force-pushed the lazygit-deps-1 branch 3 times, most recently from fb6ad41 to fdddf3a Compare September 3, 2026 07:36
@misaka00251 misaka00251 added this to the 2026.09 milestone Sep 3, 2026
cl2t added 9 commits September 3, 2026 17:34
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
cl2t added 29 commits September 3, 2026 17:34
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Signed-off-by: cl2t <yihong.or@isrc.iscas.ac.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Assistance AI is used to help with portions of code, tests, or documentation. BuildSystem: golang Issue/PR related to golang BuildSystem. BuildSystem: golangmodule Issue/PR related to golangmodule BuildSystem. Community: Student contribution Used by contributors that are currently students at an educational institution. Target: Rolling Targeting rolling/current branch. Workflow: In Review Issues that are undergoing code review and/or undergoing design review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants