[GOV-75] #160
Open
[GOV-75] #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecssary cvs enabled kafka port
Spliiting on Spliiting on
Removed unnecssary cvs enabled kafka port
fynmanoj
requested changes
Mar 24, 2024
| @@ -0,0 +1,6 @@ | |||
| id,request_id,payment_mode,payer_identifier_type,payer_identifier,payee_identifier_type,payee_identifier,amount,currency,note | |||
Contributor
There was a problem hiding this comment.
This looks like a generated file. Remove this from commit
| } catch (IOException e) { | ||
| logger.error("Failed to write sub-batch file: " + filename, e); | ||
| } | ||
| writer.close(); |
Contributor
There was a problem hiding this comment.
Why the writer close is removed?
Contributor
There was a problem hiding this comment.
Since, I have used writer with try-with resource statement it automatically closes writer irrespectve of whether writing occurs or an exception is thrown.
Unnecessary file, review comment
fynmanoj
approved these changes
Mar 28, 2024
Contributor
|
The build is failing here. Can you check ? |
Contributor
|
I have re-run all checks, its passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[].Format:
[jira_ticket] descriptionex: [phee-123] PR title.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Created/updated unit or integration tests for verifying the changes made.
Added required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing