-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Setup application modules #2760
feat: Setup application modules #2760
Conversation
This reverts commit f31a0b6.
@Nagarjuna0033 why does this PR contains
|
I think I created a branch from the from that branch (auth module migration) so that module changes also appearing |
Okay no issue, copy the |
@Nagarjuna0033 also update Also check files inside of
Mention me after this changes we'll merge this PR |
@niyajali brother I have done with the changes and also to integrate login page and we have to modify navigation and other things that I will do in the auth PR, so, if possible, can you merge this and I will integrate Login and registration in that (Previous PR) |
Okay, fix requested changes and let us know we'll merge this PR |
|
@Nagarjuna0033 I told you to copy the keystore and other files multiple times and you didn't copied the file see this PR doesn't contain keystore file how does the workflow will run without it, see my comments - #2760 (comment), #2760 (comment), #2760 (comment), #2754 (comment) |
Also, I told to rename all package names you're renamed it on one place and leave other areas, and also told you to copy |
And you haven't used the recent logo which has been used for this app and doesn't remove the unnecessary files, causing build error
|
take a look at this file - https://github.com/openMF/mifos-mobile/blob/21562c3a35889635c97e90004ebe31ed794cf5a7/cmp-android/src/main/res/drawable/ic_launcher_foreground.xml - you guys are copying the things blindly |
Fixes - Jira-#128
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
|
|
|
|
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew check
orci-prepush.sh
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.