Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup application modules #2760

Merged
merged 12 commits into from
Feb 7, 2025

Conversation

Nagarjuna0033
Copy link
Contributor

@Nagarjuna0033 Nagarjuna0033 commented Feb 6, 2025

Fixes - Jira-#128

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before After

| | | |

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@niyajali
Copy link
Collaborator

niyajali commented Feb 6, 2025

@Nagarjuna0033 why does this PR contains feature:auth module changes and copy the keystore folder and also copy workflows from the kmp-template project

@Nagarjuna0033
Copy link
Contributor Author

Nagarjuna0033 commented Feb 6, 2025

@Nagarjuna0033 why does this PR contains feature:auth module changes and copy the keystore folder and also copy workflows from the kmp-template project

I think I created a branch from the from that branch (auth module migration) so that module changes also appearing
ok I will copy work store and workflow folders

fastlane-config/android_config.rb Show resolved Hide resolved
fastlane-config/android_config.rb Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
cmp-android/build.gradle.kts Outdated Show resolved Hide resolved
cmp-android/build.gradle.kts Show resolved Hide resolved
ci-prepush.bat Outdated Show resolved Hide resolved
@niyajali
Copy link
Collaborator

niyajali commented Feb 6, 2025

@Nagarjuna0033 why does this PR contains feature:auth module changes and copy the keystore folder and also copy workflows from the kmp-template project

I think I created a branch from the from that branch (auth module migration) so that module changes also appearing ok I will copy work store and workflow folders

Okay no issue, copy the keystore from development branch also update configuration from cmp-android gradle file

@niyajali
Copy link
Collaborator

niyajali commented Feb 7, 2025

@Nagarjuna0033 also update ci-prepush.sh file and copy this file https://github.com/openMF/mifos-mobile/blob/development/.github/workflows/upload-demo-app-on-firebase.yaml and if feature:auth module is migrated to CMP in this PR, then show Login screen instead of sample blank screen

Also check files inside of script directory if we need to change any package name or not, if required change the package names

name: Upload Demo App on Firebase // Add KMP suffix like `Upload Demo App on Firebase KMP`
  pull_request:
    types: [ labeled ]
    branches:
      - 'development' # Remove this branches and add 'kmp-impl' branch
      - 'master'

Mention me after this changes we'll merge this PR

@niyajali niyajali changed the title Setting application modules feat: Setup application modules Feb 7, 2025
@Nagarjuna0033
Copy link
Contributor Author

@Nagarjuna0033 also update ci-prepush.sh file and copy this file https://github.com/openMF/mifos-mobile/blob/development/.github/workflows/upload-demo-app-on-firebase.yaml and if feature:auth module is migrated to CMP in this PR, then show Login screen instead of sample blank screen

Also check files inside of script directory if we need to change any package name or not, if required change the package names

name: Upload Demo App on Firebase // Add KMP suffix like `Upload Demo App on Firebase KMP`
  pull_request:
    types: [ labeled ]
    branches:
      - 'development' # Remove this branches and add 'kmp-impl' branch
      - 'master'

Mention me after this changes we'll merge this PR

@niyajali brother I have done with the changes and also to integrate login page and we have to modify navigation and other things that I will do in the auth PR, so, if possible, can you merge this and I will integrate Login and registration in that (Previous PR)

.github/workflows/upload-demo-app-on-firebase.yaml Outdated Show resolved Hide resolved
.github/workflows/upload-demo-app-on-firebase.yaml Outdated Show resolved Hide resolved
fastlane-config/android_config.rb Outdated Show resolved Hide resolved
fastlane-config/android_config.rb Show resolved Hide resolved
@niyajali
Copy link
Collaborator

niyajali commented Feb 7, 2025

@Nagarjuna0033 also update ci-prepush.sh file and copy this file https://github.com/openMF/mifos-mobile/blob/development/.github/workflows/upload-demo-app-on-firebase.yaml and if feature:auth module is migrated to CMP in this PR, then show Login screen instead of sample blank screen
Also check files inside of script directory if we need to change any package name or not, if required change the package names

name: Upload Demo App on Firebase // Add KMP suffix like `Upload Demo App on Firebase KMP`
  pull_request:
    types: [ labeled ]
    branches:
      - 'development' # Remove this branches and add 'kmp-impl' branch
      - 'master'

Mention me after this changes we'll merge this PR

@niyajali brother I have done with the changes and also to integrate login page and we have to modify navigation and other things that I will do in the auth PR, so, if possible, can you merge this and I will integrate Login and registration in that (Previous PR)

Okay, fix requested changes and let us know we'll merge this PR

@Nagarjuna0033
Copy link
Contributor Author

@Nagarjuna0033 also update ci-prepush.sh file and copy this file https://github.com/openMF/mifos-mobile/blob/development/.github/workflows/upload-demo-app-on-firebase.yaml and if feature:auth module is migrated to CMP in this PR, then show Login screen instead of sample blank screen
Also check files inside of script directory if we need to change any package name or not, if required change the package names

name: Upload Demo App on Firebase // Add KMP suffix like `Upload Demo App on Firebase KMP`
  pull_request:
    types: [ labeled ]
    branches:
      - 'development' # Remove this branches and add 'kmp-impl' branch
      - 'master'

Mention me after this changes we'll merge this PR

@niyajali brother I have done with the changes and also to integrate login page and we have to modify navigation and other things that I will do in the auth PR, so, if possible, can you merge this and I will integrate Login and registration in that (Previous PR)

Okay, fix requested changes and let us know we'll merge this PR

@niyajali

@niyajali niyajali enabled auto-merge (squash) February 7, 2025 15:58
@niyajali niyajali disabled auto-merge February 7, 2025 15:59
@niyajali niyajali merged commit 21562c3 into openMF:kmp-impl Feb 7, 2025
@niyajali
Copy link
Collaborator

niyajali commented Feb 7, 2025

@Nagarjuna0033 I told you to copy the keystore and other files multiple times and you didn't copied the file see this PR doesn't contain keystore file how does the workflow will run without it, see my comments - #2760 (comment), #2760 (comment), #2760 (comment), #2754 (comment)

@niyajali
Copy link
Collaborator

niyajali commented Feb 7, 2025

Also, I told to rename all package names you're renamed it on one place and leave other areas, and also told you to copy fastlane, fastlane-config directories from the development branch you copied a few files and left other files, really brother I'm done reviewing your's PR

@niyajali
Copy link
Collaborator

niyajali commented Feb 7, 2025

And you haven't used the recent logo which has been used for this app and doesn't remove the unnecessary files, causing build error


Execution failed for task ':cmp-android:processDemoReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
   > Android resource linking failed
     cmp.android.app.cmp-android-main-85:/drawable/splash_icon.xml:13: error: resource color/white (aka org.mifos.mobile.demo:color/white) not found.
     error: failed linking file resources.

@niyajali
Copy link
Collaborator

niyajali commented Feb 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants