Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [:feature:auth] - Migrated to CMP #2754

Closed
wants to merge 5 commits into from
Closed

Feat: [:feature:auth] - Migrated to CMP #2754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14d40d9
Feat: [:feature:auth] - Migrated to KMP
Nagarjuna0033 Jan 28, 2025
78a69d5
Refactor: refactored viewmodels
Nagarjuna0033 Jan 29, 2025
889a8cb
Refactor: fixed some suggestions
Nagarjuna0033 Jan 31, 2025
fd8f333
feat: added application modules
Nagarjuna0033 Feb 5, 2025
fcff923
Revert "feat: added application modules"
Nagarjuna0033 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/master_dev_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
id: dependencyguard_baseline
if: steps.dependencyguard_verify.outcome == 'failure' && github.event_name == 'pull_request'
run: |
./gradlew dependencyGuardBaseline
./gradlew :mifos-android:dependencyGuard

- name: Push new Dependency Guard baselines if available
uses: stefanzweifel/git-auto-commit-action@v5
Expand All @@ -122,7 +122,8 @@ jobs:

- name: Run tests
run: |
./gradlew testDebug :lint:test :androidApp:lintRelease :lint:lint
./gradlew :mifos-android:testDemoDebug
# ./gradlew testDebug :lint:test :androidApp:lintRelease :lint:lint

- name: Upload reports
if: always()
Expand Down Expand Up @@ -176,7 +177,7 @@ jobs:
java-version: 17

- name: Build APKs
run: ./gradlew :androidApp:assembleDebug
run: ./gradlew :mifos-android:assembleDemoDebug

- name: Upload APKs
uses: actions/upload-artifact@v4
Expand Down
70 changes: 70 additions & 0 deletions .run/mifospay-android.run.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
<component name="ProjectRunConfigurationManager">
<configuration default="false" name="androidApp" type="AndroidRunConfigurationType" factoryName="Android App" activateToolWindowBeforeRun="false">
<module name="mobile-wallet.mifospay-android.main" />
<option name="DEPLOY" value="true" />
<option name="DEPLOY_APK_FROM_BUNDLE" value="false" />
<option name="DEPLOY_AS_INSTANT" value="false" />
<option name="ARTIFACT_NAME" value="" />
<option name="PM_INSTALL_OPTIONS" value="" />
<option name="ALL_USERS" value="false" />
<option name="ALWAYS_INSTALL_WITH_PM" value="false" />
<option name="CLEAR_APP_STORAGE" value="false" />
<option name="DYNAMIC_FEATURES_DISABLED_LIST" value="" />
<option name="ACTIVITY_EXTRA_FLAGS" value="" />
<option name="MODE" value="default_activity" />
<option name="RESTORE_ENABLED" value="false" />
<option name="RESTORE_FILE" value="" />
<option name="CLEAR_LOGCAT" value="false" />
<option name="SHOW_LOGCAT_AUTOMATICALLY" value="false" />
<option name="TARGET_SELECTION_MODE" value="DEVICE_AND_SNAPSHOT_COMBO_BOX" />
<option name="SELECTED_CLOUD_MATRIX_CONFIGURATION_ID" value="-1" />
<option name="SELECTED_CLOUD_MATRIX_PROJECT_ID" value="" />
<option name="DEBUGGER_TYPE" value="Auto" />
<Auto>
<option name="USE_JAVA_AWARE_DEBUGGER" value="false" />
<option name="SHOW_STATIC_VARS" value="true" />
<option name="WORKING_DIR" value="" />
<option name="TARGET_LOGGING_CHANNELS" value="lldb process:gdb-remote packets" />
<option name="SHOW_OPTIMIZED_WARNING" value="true" />
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" />
<option name="DEBUG_SANDBOX_SDK" value="false" />
</Auto>
<Hybrid>
<option name="USE_JAVA_AWARE_DEBUGGER" value="false" />
<option name="SHOW_STATIC_VARS" value="true" />
<option name="WORKING_DIR" value="" />
<option name="TARGET_LOGGING_CHANNELS" value="lldb process:gdb-remote packets" />
<option name="SHOW_OPTIMIZED_WARNING" value="true" />
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" />
<option name="DEBUG_SANDBOX_SDK" value="false" />
</Hybrid>
<Java>
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" />
<option name="DEBUG_SANDBOX_SDK" value="false" />
</Java>
<Native>
<option name="USE_JAVA_AWARE_DEBUGGER" value="false" />
<option name="SHOW_STATIC_VARS" value="true" />
<option name="WORKING_DIR" value="" />
<option name="TARGET_LOGGING_CHANNELS" value="lldb process:gdb-remote packets" />
<option name="SHOW_OPTIMIZED_WARNING" value="true" />
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" />
<option name="DEBUG_SANDBOX_SDK" value="false" />
</Native>
<Profilers>
<option name="ADVANCED_PROFILING_ENABLED" value="false" />
<option name="STARTUP_PROFILING_ENABLED" value="false" />
<option name="STARTUP_CPU_PROFILING_ENABLED" value="false" />
<option name="STARTUP_CPU_PROFILING_CONFIGURATION_NAME" value="Java/Kotlin Method Sample (legacy)" />
<option name="STARTUP_NATIVE_MEMORY_PROFILING_ENABLED" value="false" />
<option name="NATIVE_MEMORY_SAMPLE_RATE_BYTES" value="2048" />
</Profilers>
<option name="DEEP_LINK" value="" />
<option name="ACTIVITY_CLASS" value="" />
<option name="SEARCH_ACTIVITY_IN_GLOBAL_SCOPE" value="false" />
<option name="SKIP_ACTIVITY_VALIDATION" value="false" />
<method v="2">
<option name="Android.Gradle.BeforeRunTask" enabled="true" />
</method>
</configuration>
</component>
24 changes: 24 additions & 0 deletions .run/mifospay-desktop.run.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<component name="ProjectRunConfigurationManager">
<configuration default="false" name="mifospay-desktop" type="GradleRunConfiguration" factoryName="Gradle">
<ExternalSystemSettings>
<option name="executionName" />
<option name="externalProjectPath" value="$PROJECT_DIR$" />
<option name="externalSystemIdString" value="GRADLE" />
<option name="scriptParameters" value="-DmainClass=MainKt --quiet" />
<option name="taskDescriptions">
<list />
</option>
<option name="taskNames">
<list>
<option value=":mifospay-desktop:desktopRun" />
</list>
</option>
<option name="vmOptions" />
</ExternalSystemSettings>
<ExternalSystemDebugServerProcess>true</ExternalSystemDebugServerProcess>
<ExternalSystemReattachDebugProcess>true</ExternalSystemReattachDebugProcess>
<DebugAllEnabled>false</DebugAllEnabled>
<RunAsTest>false</RunAsTest>
<method v="2" />
</configuration>
</component>
24 changes: 24 additions & 0 deletions .run/mifospay-web-js.run.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<component name="ProjectRunConfigurationManager">
<configuration default="false" name="mifospay-web-js" type="GradleRunConfiguration" factoryName="Gradle">
<ExternalSystemSettings>
<option name="executionName" />
<option name="externalProjectPath" value="$PROJECT_DIR$" />
<option name="externalSystemIdString" value="GRADLE" />
<option name="scriptParameters" value="" />
<option name="taskDescriptions">
<list />
</option>
<option name="taskNames">
<list>
<option value=":mifospay-web:jsBrowserRun" />
</list>
</option>
<option name="vmOptions" />
</ExternalSystemSettings>
<ExternalSystemDebugServerProcess>true</ExternalSystemDebugServerProcess>
<ExternalSystemReattachDebugProcess>true</ExternalSystemReattachDebugProcess>
<DebugAllEnabled>false</DebugAllEnabled>
<RunAsTest>false</RunAsTest>
<method v="2" />
</configuration>
</component>
24 changes: 24 additions & 0 deletions .run/mifospay-web-wasm.run.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<component name="ProjectRunConfigurationManager">
<configuration default="false" name="mifospay-web-wasm" type="GradleRunConfiguration" factoryName="Gradle">
<ExternalSystemSettings>
<option name="executionName" />
<option name="externalProjectPath" value="$PROJECT_DIR$" />
<option name="externalSystemIdString" value="GRADLE" />
<option name="scriptParameters" value="" />
<option name="taskDescriptions">
<list />
</option>
<option name="taskNames">
<list>
<option value=":mifospay-web:wasmJsBrowserRun" />
</list>
</option>
<option name="vmOptions" />
</ExternalSystemSettings>
<ExternalSystemDebugServerProcess>true</ExternalSystemDebugServerProcess>
<ExternalSystemReattachDebugProcess>true</ExternalSystemReattachDebugProcess>
<DebugAllEnabled>false</DebugAllEnabled>
<RunAsTest>false</RunAsTest>
<method v="2" />
</configuration>
</component>
56 changes: 27 additions & 29 deletions androidApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ plugins {
alias(libs.plugins.mifos.android.application)
alias(libs.plugins.mifos.android.application.compose)
alias(libs.plugins.mifos.android.application.flavors)
alias(libs.plugins.mifos.android.hilt)
id("com.google.android.gms.oss-licenses-plugin")
}

Expand Down Expand Up @@ -84,27 +83,27 @@ dependencies {
implementation(projects.core.ui)
implementation(projects.core.designsystem)

implementation(projects.feature.loan)
implementation(projects.feature.beneficiary)
implementation(projects.feature.guarantor)
implementation(projects.feature.savings)
implementation(projects.feature.qr)
implementation(projects.feature.transferProcess)
implementation(projects.feature.account)
implementation(projects.feature.clientCharge)
implementation(projects.feature.recentTransaction)
implementation(projects.feature.thirdPartyTransfer)
implementation(projects.feature.help)
implementation(projects.feature.notification)
implementation(projects.feature.location)
implementation(projects.feature.about)
implementation(projects.feature.settings)
implementation(projects.feature.updatePassword)
implementation(projects.feature.home)
// implementation(projects.feature.loan)
// implementation(projects.feature.beneficiary)
// implementation(projects.feature.guarantor)
// implementation(projects.feature.savings)
// implementation(projects.feature.qr)
// implementation(projects.feature.transferProcess)
// implementation(projects.feature.account)
// implementation(projects.feature.clientCharge)
// implementation(projects.feature.recentTransaction)
// implementation(projects.feature.thirdPartyTransfer)
// implementation(projects.feature.help)
// implementation(projects.feature.notification)
// implementation(projects.feature.location)
// implementation(projects.feature.about)
// implementation(projects.feature.settings)
// implementation(projects.feature.updatePassword)
// implementation(projects.feature.home)
implementation(projects.feature.auth)
implementation(projects.feature.userProfile)
// implementation(projects.feature.userProfile)

implementation(projects.libs.mifosPasscode)
// implementation(projects.libs.mifosPasscode)

// Jetpack Compose
implementation(libs.androidx.appcompat)
Expand All @@ -120,7 +119,6 @@ dependencies {
implementation(libs.androidx.compose.ui.tooling.preview)
implementation(libs.androidx.compose.ui.util)
implementation(libs.androidx.lifecycle.runtimeCompose)
implementation(libs.androidx.hilt.navigation.compose)

implementation(libs.androidx.core.splashscreen)

Expand All @@ -129,15 +127,15 @@ dependencies {
implementation(libs.google.oss.licenses)
implementation(libs.androidx.multidex)

testImplementation(projects.core.testing)
testImplementation(libs.hilt.android.testing)
testImplementation(libs.work.testing)
// testImplementation(projects.core.testing)
// testImplementation(libs.hilt.android.testing)
// testImplementation(libs.work.testing)

androidTestImplementation(kotlin("test"))
androidTestImplementation(projects.core.testing)
androidTestImplementation(libs.androidx.test.espresso.core)
androidTestImplementation(libs.androidx.navigation.testing)
androidTestImplementation(libs.hilt.android.testing)
// androidTestImplementation(kotlin("test"))
// androidTestImplementation(projects.core.testing)
// androidTestImplementation(libs.androidx.test.espresso.core)
// androidTestImplementation(libs.androidx.navigation.testing)
// androidTestImplementation(libs.hilt.android.testing)

debugApi(libs.androidx.compose.ui.tooling)
}
Loading