Profile photo not refreshing after upload in Client Profile #2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim.1DD19614-3186-4A87-B516-55F18FA6BC55.MOV |
revanthkumarJ
suggested changes
Oct 9, 2025
| when (event) { | ||
| ClientProfileEditEvent.NavigateBack -> onNavigateBack() | ||
| ClientProfileEditEvent.OnSaveSuccess -> { | ||
| onNavigateBack() |
There was a problem hiding this comment.
I commented it because it is not needed for the navigation, and it is excess code
The screen navigation works well with or without it
There was a problem hiding this comment.
Remove it if not needed
| MifosBasicDialog( | ||
| title = "Success", | ||
| content = { Text("Your profile image has been updated successfully!") }, | ||
| confirmText = "Done", |
There was a problem hiding this comment.
use Success and Failure Dilaogs instead of Basic Dialog.
There was a problem hiding this comment.
This one
MifosStatusDialog
which accepts success and Failure state and also move strings to string resources
biplab1
reviewed
Oct 10, 2025
Comment on lines
424
to
426
| <string name="feature_client_profile_update_success_message">Your profile image has been updated successfully!</string> | ||
| <string name="feature_client_profile_update_error_message">We couldn’t update your profile image. Please try again.</string> | ||
| <string name="should_refresh">should_refresh</string> |
There was a problem hiding this comment.
This should be added to feature:client's commonMain strings.xml (android-client\feature\client\src\commonMain\composeResources\values\strings.xml)
There was a problem hiding this comment.
Oh okay, I will do that and push it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#Issue_Number
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.