feat: Migrate :core:datastore module to KMP
#2291
Conversation
|
@kapmaurya dataState wrapper should be in common, for now let it be after merging common you can remove from this module and use it from common and also mifosDispatcher will be present in common module |
niyajali
changed the title
:core:datastore module to KMP
|
|
||
| //expect annotation class IgnoredOnParcel() | ||
|
|
||
| expect interface Parceler<P> { |
There was a problem hiding this comment.
remove Parcelize class implementation from this module you no need in this module, it should be in common module.
There was a problem hiding this comment.
@kapmaurya have you used that class anywhere in this module.
| started = SharingStarted.Eagerly, | ||
| ) | ||
|
|
||
| override val defaultAccountId: StateFlow<Long?> |
There was a problem hiding this comment.
I don't think you needed account id in this project update this data source according to android-client project take a look at old PreferenceManger class and implement those thing only and remove remaining functions
There was a problem hiding this comment.
@kapmaurya clientId and defaultAccountId those are there in mifos-mobile , just use the arguments which are there in preferenceManager before conversion only. I think only user is there in it
|
|
||
| private const val USER_INFO_KEY = "userInfo" | ||
| private const val CLIENT_INFO_KEY = "clientInfo" | ||
|
|
There was a problem hiding this comment.
Update this class accordingly for this project
| @@ -7,7 +7,7 @@ androidDesugarJdkLibs = "2.1.4" | |||
| androidIconifyMaterial = "2.2.2" | |||
| androidJob = "1.2.6" | |||
| androidMapsUtils = "0.4.2" | |||
| androidGradlePlugin = "8.8.0" | |||
| androidGradlePlugin = "8.7.2" | |||
There was a problem hiding this comment.
why you're downgrading the version, use AGP 8.8.0 or later
|
@kapmaurya ask Revnath for help, connect with him and fix above issues |
|
@kapmaurya and regarding DataState if you want to merge this PR first then replace DataState with default kotlin ones like Response.success otherwise as common module is also your task complete it first merge it and then use that DataState here |
|
@kapmaurya you can refer revanthkumarJ@bc03d5b I think there is no need to use Parcelize, it is not used in mobile-wallet and mifos mobile dataStore Similarly search what are the viewmodels and others using PreferenceManager if needed add other data models |
therajanmaurya
force-pushed
the
Datastore-migrate-kmpl
branch
from
c307045 to
8e864ad
Compare
| dependencies { | ||
| api(projects.core.model) | ||
| api(projects.core.common) | ||
|
|
||
| api(libs.converter.gson) | ||
|
|
||
| // fineract sdk dependencies | ||
| api(libs.mifos.android.sdk.arch) | ||
|
|
||
| // sdk client | ||
| api(libs.fineract.client) | ||
| kotlin { | ||
| sourceSets { | ||
| commonMain.dependencies { | ||
| implementation(libs.multiplatform.settings) | ||
| implementation(libs.multiplatform.settings.serialization) | ||
| implementation(libs.multiplatform.settings.coroutines) | ||
| implementation(libs.kotlinx.coroutines.core) | ||
| implementation(libs.kotlinx.serialization.core) | ||
| // implementation(projects.core.common) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
why it's inside the dependencies block?
| //import com.russhwolf.settings.serialization.decodeValueOrNull | ||
| //import com.russhwolf.settings.serialization.encodeValue | ||
| //import kotlinx.coroutines.CoroutineDispatcher | ||
| // |
There was a problem hiding this comment.
if these commented code not required remove it
| // } | ||
| // | ||
| // fun setPermissionDeniedStatus(permissionDeniedStatus: String, status: Boolean) { | ||
| // preference.edit().putBoolean(permissionDeniedStatus, status).apply() |
There was a problem hiding this comment.
remove this file as you converted this in commonMain
| alias(libs.plugins.mifos.android.library.jacoco) | ||
| alias(libs.plugins.mifos.android.hilt) | ||
| alias(libs.plugins.mifos.kmp.library) | ||
| //id(libs.plugins.kotlin.parcelize.get().pluginId) |
There was a problem hiding this comment.
remove //id(libs.plugins.kotlin.parcelize.get().pluginId)
| "identityHash": "52a9a8b64b78975c74e557a9c0411c25", | ||
| "entities": [ | ||
| { | ||
| "tableName": "ColumnValue", |
There was a problem hiding this comment.
I think this file is not needed during dataStoreMigration
…into Datastore-migrate-kmpl # Conflicts: # core/datastore/src/commonMain/kotlin/org.mifos.core.datastore/UserPreferencesDataSource.kt
Fixes - Jira-#Issue_Number
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.