Skip to content

fix: Collection sheet Keeps on loading even the internet is turned of… #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Collection sheet Keeps on loading even the internet is turned of… #2071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...fos/mifosxdroid/online/collectionsheetindividual/NewIndividualCollectionSheetViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import rx.Subscriber
import rx.android.schedulers.AndroidSchedulers
import rx.plugins.RxJavaPlugins
import rx.schedulers.Schedulers
import java.net.UnknownHostException
import javax.inject.Inject

/**
Expand Down Expand Up @@ -86,6 +87,10 @@ class NewIndividualCollectionSheetViewModel @Inject constructor(private val repo
_newIndividualCollectionSheetUiState.value =
NewIndividualCollectionSheetUiState.ShowError(errorMessage)
}
else if (e is UnknownHostException) {
_newIndividualCollectionSheetUiState.value =
NewIndividualCollectionSheetUiState.ShowError("No internet connection")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use strings.xml and don't use hard coded strings

}
} catch (throwable: Throwable) {
RxJavaPlugins.getInstance().errorHandler.handleError(e)
}
Expand Down Expand Up @@ -114,6 +119,10 @@ class NewIndividualCollectionSheetViewModel @Inject constructor(private val repo
_newIndividualCollectionSheetUiState.value =
NewIndividualCollectionSheetUiState.ShowError(errorMessage)
}
else if (e is UnknownHostException) {
_newIndividualCollectionSheetUiState.value =
NewIndividualCollectionSheetUiState.ShowError("No internet connection")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use strings.xml and don't use hard coded strings

}
} catch (throwable: Throwable) {
RxJavaPlugins.getInstance().errorHandler.handleError(e)
}
Expand Down