Skip to content

feat: add Windows x64 (MSVC) platform support#202

Open
br-to wants to merge 1 commit intoopen-wallet-standard:mainfrom
br-to:feat/windows-x64-support
Open

feat: add Windows x64 (MSVC) platform support#202
br-to wants to merge 1 commit intoopen-wallet-standard:mainfrom
br-to:feat/windows-x64-support

Conversation

@br-to
Copy link
Copy Markdown

@br-to br-to commented Apr 10, 2026

Summary

Adds x86_64-pc-windows-msvc target across the entire build and distribution pipeline so that npm install @open-wallet-standard/core works on Windows x64 without the Cannot find module '@open-wallet-standard/core-win32-x64-msvc' error.

Currently the optionalDependencies in package.json and the CI build matrix only include macOS and Linux targets. Windows users hit a hard failure at runtime because the platform-specific npm package (core-win32-x64-msvc) is never built or published.

Changes

  • bindings/node/npm/win32-x64-msvc/package.json — new platform package for Windows x64 (mirrors existing darwin/linux packages)
  • bindings/node/package.json — add x86_64-pc-windows-msvc to napi triples and @open-wallet-standard/core-win32-x64-msvc to optionalDependencies
  • bindings/node/bin/ows — add win32-x64 entry to PLATFORM_MAP (resolves to ows.exe)
  • .github/workflows/release.yml — add windows-latest to build matrix for:
    • CLI binary build (build job)
    • Node.js native addon build (node-addons job)
    • Python wheel build (python-wheels job)
    • CLI binary copy into npm platform package (publish-npm job)
    • Windows-specific handling for .exe extension in rename/upload steps
    • shell: bash for set-version.sh on Windows runners

Platform matrix (after this PR)

Platform npm package Rust target Build OS
macOS ARM core-darwin-arm64 aarch64-apple-darwin macos-latest
macOS x64 core-darwin-x64 x86_64-apple-darwin macos-latest
Linux x64 core-linux-x64-gnu x86_64-unknown-linux-gnu ubuntu-latest
Linux ARM core-linux-arm64-gnu aarch64-unknown-linux-gnu ubuntu-latest
Windows x64 core-win32-x64-msvc x86_64-pc-windows-msvc windows-latest

Closes #136

Test plan

  • CI builds pass on windows-latest for all three jobs (build, node-addons, python-wheels)
  • npx napi build --platform --release --target x86_64-pc-windows-msvc produces ows-node.win32-x64-msvc.node
  • cargo build --release --target x86_64-pc-windows-msvc produces ows.exe in ows/ workspace
  • npm install @open-wallet-standard/core on Windows x64 resolves core-win32-x64-msvc without errors
  • ows CLI launches correctly on Windows via the Node.js bin wrapper

🤖 Generated with Claude Code

Add x86_64-pc-windows-msvc target to CI/CD build matrix and npm
distribution so that `npm install @open-wallet-standard/core` works
on Windows without the "Cannot find module core-win32-x64-msvc" error.

Closes open-wallet-standard#136

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@br-to br-to requested a review from njdawn as a code owner April 10, 2026 14:15
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

@br-to is attempting to deploy a commit to the MoonPay Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​open-wallet-standard/​core-win32-x64-msvc@​1.2.4100100100100100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Windows 11 and Android platform support

1 participant