fix(cli): append v byte to EVM signMessage output#188
Open
teyrebaz33 wants to merge 1 commit intoopen-wallet-standard:mainfrom
Open
fix(cli): append v byte to EVM signMessage output#188teyrebaz33 wants to merge 1 commit intoopen-wallet-standard:mainfrom
teyrebaz33 wants to merge 1 commit intoopen-wallet-standard:mainfrom
Conversation
The CLI was returning 64-byte signatures (r + s only) instead of the expected 65-byte format (r + s + v). The recovery ID was available in the recoveryId field but not appended to the signature hex. Fixes open-wallet-standard#171
|
@teyrebaz33 is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
ows sign message --chain evmreturns 64-byte signatures (r + s) instead of the expected 65 bytes (r + s + v), causingecrecoverfailures in ERC-8128 and EIP-191 verification flows.Fixes #171
Root cause
In
sign_message.rs, the owner mode path encoded onlyoutput.signature(64 bytes) without appending the recovery ID as thevbyte. TherecoveryIdfield was correct but not included in the hex output.Fix
Append
v(normalized to 27/28) to the signature bytes before hex-encoding:Notes