docs: clarify sign_message contract across chains#185
Open
teyrebaz33 wants to merge 2 commits intoopen-wallet-standard:mainfrom
Open
docs: clarify sign_message contract across chains#185teyrebaz33 wants to merge 2 commits intoopen-wallet-standard:mainfrom
teyrebaz33 wants to merge 2 commits intoopen-wallet-standard:mainfrom
Conversation
|
@teyrebaz33 is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
Addresses the design questions raised in open-wallet-standard#183: 1. sign_message IS a user-facing cross-chain off-chain signing primitive, not a raw-byte escape hatch (use sign() for that). 2. It only exists where there is a recognized ecosystem convention. Chains without one SHOULD return CHAIN_NOT_SUPPORTED. 3. The interface is not a low-level utility — raw-byte signing under sign_message falsely implies interoperability that does not exist. 4. Transaction signing (sign/signAndSend) and off-chain message signing (signMessage) remain strictly separate. EIP-712 typed data is a third distinct operation (signTypedData). 5. Filecoin, Solana, and TON currently sign raw/hashed bytes without a recognized off-chain envelope — documented as a compatibility behavior, not the intended design. Added a chain behavior table, design intent section, and guidance for contributors adding new chains (e.g. Nano): a canonical specification is required before sign_message support can be added. Removed typedData from SignMessageRequest (use signTypedData instead).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the intended contract of
signMessageacross chains in the signing interface spec.Changes
signMessageuses each chain's message-signing conventionsignMessagerequest shapesignTypedDataVerification
origin/mainNotes
cargois not installedCloses #183