-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user_agent.*
wording to support multiple apps
#680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
such as microservices with multiple applications
I didn't really follow, what would be an example this? thx
hey @trask sorry that it's not clear, probably I need to rephrase it anyway in this case. I refer to the comments like |
@trask @joaopgrassi I have rephrased it. Please check it out |
Hi @trisch-me ! We changed how the CHANGELOG.md is managed. Please take a look at https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#adding-a-changelog-entry to see what needs to be done. Sorry for the disruption. |
hey @joaopgrassi I haven't updated the changelog because it's only a new wording without bigger changes. Please let me know if you think I need to create a new entry for this PR |
user_agent.*
wording to support multiple apps
@joaopgrassi The same problem as in your recent PR (with WIP label), I don't have changes for changelog for this trivial PR but the job is failing and I don't have access to the labels in my current role. |
@trisch-me You can prefix the PR title with |
@arminru I will add changelog entry but I think we need to update our rules as well. There are editorial PRs etc, we could add labels automatically using github actions |
For editorial PRs, if either the PR title is prefixed with Since merging is always done by a person and not a workflow, that person can just add the label as the very last action right before merging the PR (or the PR author themselves adds the PR title prefix). Until merging it's not an issue if that one merge check fails except for the visual cue it carries. |
…y#680) Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Joao Grassi <[email protected]>
Fixes #662
Changes
Merge requirement checklist