-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CICD metrics #1681
Add CICD metrics #1681
Conversation
This ensures that all result values are nouns.
Overall LGTM. A small (non-blocking) question: were |
No I did not consider it until now. It's only with the latest changes that the similarity between these two metrics became apparent. I'm open to combine these two metric pairs and distinguishing them with |
Not a strong opinion, but I like the idea of merging
I don't think those are similar to
|
distinguish them by the new cicd.pipeline.run.state attribute
I have combined |
…e.run.duration we make the distinction using the attribute cicd.pipeline.run.state
This makes it clear that this count might not match the cicd.pipeline.run.duration count for result failure.
Fixes #1600
Changes
This PR adds metrics for CICD systems and related attributes.
Merge requirement checklist
[chore]