Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CICD metrics #1681

Merged

Conversation

christophe-kamphaus-jemmic
Copy link
Contributor

Fixes #1600

Changes

This PR adds metrics for CICD systems and related attributes.

Merge requirement checklist

docs/attributes-registry/cicd.md Outdated Show resolved Hide resolved
docs/cicd/cicd-metrics.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor

Overall LGTM. A small (non-blocking) question: were cicd.pipeline.run.queued and cicd.pipeline.run.active considered as a single metric, with a state or similar label? Not proposing that, just curious on whether that was considered, as they are very similar.

@christophe-kamphaus-jemmic
Copy link
Contributor Author

Overall LGTM. A small (non-blocking) question: were cicd.pipeline.run.queued and cicd.pipeline.run.active considered as a single metric, with a state or similar label? Not proposing that, just curious on whether that was considered, as they are very similar.

No I did not consider it until now. It's only with the latest changes that the similarity between these two metrics became apparent.
Also the cicd.pipeline.run.duration and cicd.pipeline.run.time_in_queue seem very similar.

I'm open to combine these two metric pairs and distinguishing them with phase attribute if additional reviewers are in favor of this change.

@lmolkova
Copy link
Contributor

lmolkova commented Jan 17, 2025

Overall LGTM. A small (non-blocking) question: were cicd.pipeline.run.queued and cicd.pipeline.run.active considered as a single metric, with a state or similar label? Not proposing that, just curious on whether that was considered, as they are very similar.

Not a strong opinion, but I like the idea of merging cicd.pipeline.run.queued and cicd.pipeline.run.active to something like cicd.pipeline.run.count with cicd.pipeline.run.state attribute.

Also the cicd.pipeline.run.duration and cicd.pipeline.run.time_in_queue seem very similar.

I don't think those are similar to cicd.pipeline.run.queued|active

  • these metrics could easily have different range (different order of magnitude) of values (e.g. time in queue is hopefully tiny and pipeline duration is measured in minutes or hours)
  • you'd configure different alerts for them and different people would pay attention to their values (in my BigCo anecdotal experience, workers are managed by a separate team/org and I have little control over them, while pipeline and its duration is controlled by dev teams)

@christophe-kamphaus-jemmic
Copy link
Contributor Author

I have combined cicd.pipeline.run.active and cicd.pipeline.run.queued into cicd.pipeline.run.active distinguishing them with the cicd.pipeline.run.state attribute in 1d88f59.

@trask trask added this to the v1.30.0 milestone Jan 20, 2025
…e.run.duration

we make the distinction using the attribute cicd.pipeline.run.state
This makes it clear that this count might not match the
cicd.pipeline.run.duration count for result failure.
model/cicd/registry.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2025
@joaopgrassi joaopgrassi merged commit 98244d9 into open-telemetry:main Jan 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add metrics for CICD job queues
10 participants