Adding additional PHP no code example #5747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobstrecansky is this draft PR still needed or do we want to raise an issue instead until the PR is ready? |
|
Either way works for me |
chalin
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Noting, for the record, that we (@bobstrecansky and SIG-comms) discussed this not to long ago and agreed that the code would be put elsewhere (not in this repo).
|
is this PR still needed/something to work on? |
|
@bobstrecansky closing this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an additional PHP no code example with reference.
Resolves: open-telemetry/opentelemetry-php#1437