Remove unwanted Arc insider PeriodicReader #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
=====================================
Coverage 79.6% 79.6%
=====================================
Files 118 118
Lines 22467 22473 +6
=====================================
+ Hits 17897 17902 +5
- Misses 4570 4571 +1 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Jan 31, 2025
| // Relying on futures executor to execute async call. | ||
| // TODO: Add timeout and pass it to exporter or consider alternative | ||
| // design to enforce timeout here. | ||
| // TODO: Pass timeout to exporter |
There was a problem hiding this comment.
Nit
Suggested change
| // TODO: Pass timeout to exporter | |
| // TODO: Pass _timeout initialized above to exporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also did a minor change to calculate timeout in Periodicreader. It is still TODO to pass it to exporter and enforce it.