-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling the Instrument Name Validation under a new feature flag #2543
Open
anujnegi270
wants to merge
13
commits into
open-telemetry:main
Choose a base branch
from
anujnegi270:anujnegi/disable-name-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Disabling the Instrument Name Validation under a new feature flag #2543
anujnegi270
wants to merge
13
commits into
open-telemetry:main
from
anujnegi270:anujnegi/disable-name-check
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujnegi270
changed the title
Disabling all type of name checks except empty names and exceeding le…
Disabling the Instrument Name Validation under a new feature flag
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2543 +/- ##
=======================================
- Coverage 79.4% 79.3% -0.2%
=======================================
Files 118 118
Lines 22526 22495 -31
=======================================
- Hits 17898 17847 -51
- Misses 4628 4648 +20 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Jan 24, 2025
lalitb
reviewed
Jan 27, 2025
…opentelemetry-rust into anujnegi/disable-name-check
lalitb
approved these changes
Jan 28, 2025
cijothomas
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the feature [Feature]: A Dev Feature for Naming Convention used in Windows Performance Counters · Issue #2527 · open-telemetry/opentelemetry-rust and a related issue .
Fixes #
This fix is done under a feature flag
experimental_metrics_disable_name_validation
, where all types of instrument name are acceptable except empty names and names exceeding the length limit.Changes
Defining the validation check function under the feature flag to bypass and return Ok().
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes