feat: Gauge metrics exporter encoding #1780
Merged
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwestbrook
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd and
kaylareopelle
as code owners
|
FYI @xuan-cao-swi since I just noticed that you mentioned you would open a PR for this on your SDK PR 😄 |
| # | ||
| # metrics [MetricData] | ||
| def as_otlp_metrics(metrics) | ||
| case metrics.instrument_kind | ||
| when :gauge |
There was a problem hiding this comment.
Is that possible to combine :observable_gauge and :gauge something like when :observable_gauge, :gauge since they are using same Proto::Metrics::V1::Gauge.
There was a problem hiding this comment.
Yeah I split them out because Proto::Metrics::V1::Gauge doesn't actually implement aggregation_temporality. Seems like that was just a mistake in the :observable_gauge implementation 😋 c32f2c0
There was a problem hiding this comment.
Ah, make sense, thanks!
kaylareopelle
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support exporting gauge metrics from
OTLP::Metrics::MetricsExporternow that support forGaugeinstruments inmetrics_sdkhas been added (#1718)