-
Notifications
You must be signed in to change notification settings - Fork 779
Add new credential provider package / GCP credential provider for OTLP Exporter #3766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+683
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
reviewed
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest move the package under exporter or sdk-extensions directory at root
aabmass
reviewed
Sep 23, 2025
...rter/exporter-credential-providers/gcp-credential-provider/tests/test_credential_provider.py
Outdated
Show resolved
Hide resolved
exporter/exporter-credential-providers/gcp-credential-provider/MANIFEST.rst
Outdated
Show resolved
Hide resolved
...metry-exporter-credential-provider-gcp/src/opentelemetry/gcp_credential_provider/__init__.py
Show resolved
Hide resolved
aabmass
approved these changes
Sep 24, 2025
exporter/exporter-credential-providers/gcp-credential-provider/pyproject.toml
Outdated
Show resolved
Hide resolved
I think this is good to be merged now |
emdneto
reviewed
Sep 25, 2025
exporter/opentelemetry-exporter-credential-provider-gcp/test-requirements.txt
Show resolved
Hide resolved
emdneto
approved these changes
Sep 29, 2025
xrmx
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a new directory for exporter credential providers. Create a new package that will enable GCP credentials to be passed to OTLP exporters via the entry point added in open-telemetry/opentelemetry-python#4689
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.