add commenter_options in trace_integration #3743
Open
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloe-zh97
changed the title
instrumentation/opentelemetry-instrumentation-dbapi/tests/test_dbapi_integration.py
Show resolved
Hide resolved
|
Hi @chloe-zh97 thanks for this. A few more requests:
|
chloe-zh97
force-pushed
the
issue-3726-trace-integration-support-args
branch
from
0fcd925 to
edb34e6
Compare
chloe-zh97
changed the title
Thanks, done. |
tammy-baylis-swi
approved these changes
Sep 10, 2025
Okay, thank you! |
xrmx
reviewed
Sep 15, 2025
CHANGELOG.md
Outdated
| ([#3734](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3734)) | ||
| - `opentelemetry-instrumentation`: botocore: upgrade moto package from 5.0.9 to 5.1.11 | ||
| ([#3736](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3736)) | ||
| - `opentelemetry-instrumentation-dbapi`: Add support for `commenter_options` in `trace_integration` to control SQLCommenter behavior |
There was a problem hiding this comment.
This needs to be moved to unreleased
xrmx
reviewed
Sep 15, 2025
| capture_parameters: bool = False, | ||
| enable_commenter: bool = False, | ||
| db_api_integration_factory: type[DatabaseApiIntegration] | None = None, | ||
| commenter_options: dict[str, Any] | None = None, |
There was a problem hiding this comment.
Since this has a default I would move it as last element so that previous callers using args would still be fine
chloe-zh97
force-pushed
the
issue-3726-trace-integration-support-args
branch
from
eb3f469 to
b232b9a
Compare
github-project-automation
bot
moved this from Ready for review
to Done
in @xrmx's Python PR digest
|
Hi @xrmx, could you help review again, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for passing
commenter_optionsto thetrace_integrationfunction andDatabaseApiIntegrationin theopentelemetry-instrumentation-dbapipackage. This allows users to customize SQLCommenter behavior (for example, disablingopentelemetry_values) when instrumenting DB-API drivers.Fixes #3726
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
test_commenter_options_propagationandtest_trace_integration_passes_commenter_optionstox -e lintandpytest.tox -e rufffor code formattingDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.