Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instrumentation/aws-lambda: don't print warnings outside of AWS Lambda #3183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

instrumentation/aws-lambda: don't print warnings outside of AWS Lambda #3183

wants to merge 1 commit into from

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jan 13, 2025

Description

If we are not running inside AWS Lambda don't print warnings on missing OTel lambda extension layer.
The instrumentation is installed by the OTel k8s operator and so this warning may confuse users.

Refs #3182

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx
instrumentation/aws-lambda: don't print warnings outside of AWS Lambda
4ca0727 
If we are not running inside AWS Lambda don't print warnings on missing
OTel lambda extension layer.
The instrumentation is installed by the OTel k8s operator and so this
warning may confuse users.
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 13, 2025
emdneto
emdneto approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS_LAMBDA_FUNCTION_NAME is a defined runtime environment variable. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

@emdneto emdneto emdneto approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrmx @emdneto @tammy-baylis-swi