Skip to content

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 18, 2025

Pulls in changes from the first prototype and applies them to the 2.0 SDK

TODO:

  • e2e tests
  • unit tests
  • add entity detectors (process/host probably a good start)
  • Make Entity a type/interface instead of a class because it is accessed from resource.entities
  • Export pipeline

Open questions:

  • Should detectors be able to detect resource attributes and entities, or just one or the other
  • verify entity merge override ordering because it's the opposite of the current resource impl

dyladan added 2 commits April 18, 2025 15:10
Pulls in changes from the first prototype and applies them to the 2.0 SDK

TODO: tests, entity detectors
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

❌ Patch coverage is 25.89286% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.11%. Comparing base (95b40aa) to head (d17b2cd).

Files with missing lines Patch % Lines
...ackages/opentelemetry-resources/src/entity-impl.ts 9.45% 67 Missing ⚠️
...kages/opentelemetry-resources/src/resource-impl.ts 54.28% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5620      +/-   ##
==========================================
- Coverage   95.06%   94.11%   -0.96%     
==========================================
  Files         307      308       +1     
  Lines        8031     8135     +104     
  Branches     1627     1653      +26     
==========================================
+ Hits         7635     7656      +21     
- Misses        396      479      +83     
Files with missing lines Coverage Δ
...l/packages/otlp-transformer/src/common/internal.ts 100.00% <100.00%> (ø)
...es/opentelemetry-resources/src/detect-resources.ts 78.57% <100.00%> (ø)
...kages/opentelemetry-resources/src/resource-impl.ts 85.71% <54.28%> (ø)
...ackages/opentelemetry-resources/src/entity-impl.ts 9.45% <9.45%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant