chore(lint): restore running prettier as part of linting #3274
+353
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Slack discussion: https://cloud-native.slack.com/archives/C08T7MZTV8W/p1764893850195369 |
github-actions
bot
assigned
blumamir,
d4nyll,
david-luna,
hectorhdzg,
JacksonWeber,
jj22ee,
martinkuba and
maryliag
github-actions
bot
added
pkg:instrumentation-kafkajs
pkg-status:unmaintained
github-actions
bot
requested review from
JacksonWeber,
d4nyll,
david-luna,
hectorhdzg,
jj22ee,
martinkuba,
maryliag,
naseemkullah,
obecny,
onurtemizkan,
pkanal,
trivikr,
wolfgangcodes and
yiyuan-he
trentm
changed the title
Contributor
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
david-luna
approved these changes
Dec 5, 2025
Contributor
david-luna
left a comment
david-luna
left a comment
There was a problem hiding this comment.
TIL declare private & private declare is allowed by the compiler.
pichlermarc
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-adds running prettier as part of the 'lint' step. There are separate
lint:prettierandlint:prettier:fixscripts if one wants to run just style checking.Refs: #3001
AFAICT prettier is no longer being run. My theory is that #3001 accidentally caused that.
Update: The accident is that we didn't follow-up after 3001 to add running
prettierseparately. Prettier's recommendation is to run prettier separate from linters, which I can get behind.