Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation): add support for NestJS 11 #2685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neilime
Copy link

@neilime neilime commented Jan 29, 2025

Which problem is this PR solving?

  • nest-core instrumentation is not supporting last version of NestJS (11)

Short description of the changes

  • Adding support for NestJS 11

Copy link

linux-foundation-easycla bot commented Jan 29, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: neilime / name: Emilien Escalle (62582a7)

@github-actions github-actions bot added pkg:instrumentation-nestjs-core pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Jan 29, 2025
@neilime neilime force-pushed the feat/nestjs-core-support-nestjs11 branch from 6747378 to 9f42c15 Compare January 29, 2025 13:13
@neilime neilime marked this pull request as ready for review January 29, 2025 14:19
@neilime neilime requested a review from a team as a code owner January 29, 2025 14:19
@neilime neilime force-pushed the feat/nestjs-core-support-nestjs11 branch from 9f42c15 to 2cc7772 Compare January 29, 2025 18:28
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@neilime neilime force-pushed the feat/nestjs-core-support-nestjs11 branch 2 times, most recently from 06d3115 to 09f29c9 Compare February 7, 2025 10:59
@neilime
Copy link
Author

neilime commented Feb 7, 2025

@dyladan any chance to have some review, or any advice to move forward with this instrumentation

@david-luna
Copy link
Contributor

Thanks for your contribution @neilime :)

you need to also update tav.yml to include the new version in test-all-versions workflow

@neilime neilime force-pushed the feat/nestjs-core-support-nestjs11 branch from d55f038 to e945812 Compare February 11, 2025 15:30
@neilime neilime force-pushed the feat/nestjs-core-support-nestjs11 branch from e945812 to 62582a7 Compare February 11, 2025 15:32
@neilime
Copy link
Author

neilime commented Feb 11, 2025

@david-luna it's done

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (7a1e8b3) to head (62582a7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2685   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         171      171           
  Lines        8142     8142           
  Branches     1647     1647           
=======================================
  Hits         7524     7524           
  Misses        618      618           
Files with missing lines Coverage Δ
...instrumentation-nestjs-core/src/instrumentation.ts 95.45% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:instrumentation-nestjs-core pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants