Complex attributes incubating implementation #7814

trask · 2025-11-05T03:43:00Z

Based on prototype option C (#7813)

codecov · 2025-11-06T00:25:31Z

Codecov Report

❌ Patch coverage is 79.23497% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (683a447) to head (9b9ea16).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...a/io/opentelemetry/sdk/internal/AttributeUtil.java	62.26%	13 Missing and 7 partials ⚠️
...r/common/ArrayBackedExtendedAttributesBuilder.java	84.61%	6 Missing and 4 partials ⚠️
...ncubator/common/ArrayBackedExtendedAttributes.java	86.20%	3 Missing and 5 partials ⚠️

❌ Your patch status has failed because the patch coverage (79.23%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7814      +/-   ##
============================================
+ Coverage     90.10%   90.13%   +0.02%     
- Complexity     7240     7322      +82     
============================================
  Files           825      825              
  Lines         21850    22032     +182     
  Branches       2136     2177      +41     
============================================
+ Hits          19688    19858     +170     
- Misses         1496     1497       +1     
- Partials        666      677      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributesBuilder.java

jkwatson

Anyone who wants to use the Value type should be scared off by looking at the complexity of the implementation. 😂 Thanks!

jack-berg · 2025-11-17T23:08:56Z

I was kinda hoping we could merge this right into the stable Attributes to reduce churn. After all, ExtendedAttributes served its job and helped provide feedback to the spec. What feedback might we get from iterating again on ExtendedAttributes? Should we weigh the probability of feedback against the cost / inconvenience of churn?

trask · 2025-11-18T00:00:26Z

we can't merge it into stable until Jan 15 (6 months after the OTEP was merged)

trask · 2025-11-18T18:15:51Z

TODO: implement attribute limits

jack-berg · 2025-11-18T21:16:28Z

TODO: implement attribute limits

Is there consensus on how to do this?

trask · 2025-11-18T21:45:55Z

Is there consensus on how to do this?

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/README.md#attribute-limits

jack-berg · 2025-11-18T21:17:43Z

...bator/src/main/java/io/opentelemetry/api/incubator/common/ArrayBackedExtendedAttributes.java

+        return asValue(currentKey.getType(), value);
+      }
+    }
+    return null;


Would this implementation benefit from #7076?

...rc/main/java/io/opentelemetry/api/incubator/common/ArrayBackedExtendedAttributesBuilder.java

...bator/src/main/java/io/opentelemetry/api/incubator/common/ArrayBackedExtendedAttributes.java

...rc/main/java/io/opentelemetry/api/incubator/common/ArrayBackedExtendedAttributesBuilder.java

jack-berg · 2025-11-24T22:57:15Z

sdk/common/src/main/java/io/opentelemetry/sdk/internal/AttributeUtil.java

+      buffer.get(truncated);
+      return Value.of(truncated);
+    } else if (type == ValueType.ARRAY) {
+      List<Value<?>> array = (List<Value<?>>) value.getValue();


The AttributeUtil.applyAttributesLimit function takes an approach of first checking if any any attribute is invalid before paying the price to create a new AttributeBuilder and rebuilding, with the limits applied to each entry.

Could take the same approach here to avoid unnecessary reconstruction of the Value if all the entries are valid. Applies to KEY_VALUE_LIST as well.

Don't necessarily need to solve it now, but let's at least leave a TODO.

sdk/common/src/main/java/io/opentelemetry/sdk/internal/ExtendedAttributesMap.java

...incubator/src/main/java/io/opentelemetry/api/incubator/common/ExtendedAttributesBuilder.java

jack-berg · 2025-11-24T23:08:07Z

...ubator/src/test/java/io/opentelemetry/api/incubator/logs/ExtendedLogsBridgeApiUsageTest.java

  AttributeKey<List<Double>> doubleArrKey = AttributeKey.doubleArrayKey("acme.double_array");

  // Extended keys
+  @SuppressWarnings("deprecation") // Supporting deprecated EXTENDED_ATTRIBUTES until removed


No need to demonstrate deprecate feature. Not sure anyone will see it, but let's go ahead on delete the usages in here of EXTENDED_ATTRIBUTES.

codecov 😭

trask force-pushed the complex-attrs-c-impl branch from f91ab1f to 6e1c6e7 Compare November 5, 2025 21:34

trask force-pushed the complex-attrs-c-impl branch 2 times, most recently from cbdcc32 to 2b69000 Compare November 8, 2025 00:09

anuraaga mentioned this pull request Nov 12, 2025

Migrate generative AI semantic conventions to OTel 1.37.0 open-telemetry/opentelemetry-java-instrumentation#15268

Open

trask added 14 commits November 13, 2025 10:53

Prototype: Complex attributes (Option C - minimal)

5e889a8

Remove String, Value<?> overload

4a2c048

Add javadoc explaining coersion

3b8e35f

more javadoc

04937c0

more javadoc

73466c8

more

1958768

Complex Attributes - incubating implementation

e4308cf

Deprecation

5f342e2

More implementation

8c40374

updates

7d49b5e

javadoc

d3f9dbe

tests

08e6e0c

javadoc

c7824e1

fix

26a3413

trask force-pushed the complex-attrs-c-impl branch from 4da140a to 26a3413 Compare November 13, 2025 19:32

Add a missing test

d83ff5d

trask commented Nov 13, 2025

View reviewed changes

api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributesBuilder.java Outdated Show resolved Hide resolved

trask added 2 commits November 13, 2025 14:32

Apply suggestion from @trask

10d6e02

codecov

198faa2

trask marked this pull request as ready for review November 13, 2025 23:23

trask requested a review from a team as a code owner November 13, 2025 23:23

trask mentioned this pull request Nov 14, 2025

Prototype: Complex attributes (Option C) #7813

Closed

jkwatson approved these changes Nov 17, 2025

View reviewed changes

lmolkova mentioned this pull request Nov 18, 2025

Stabilize new attribute value types and limits open-telemetry/opentelemetry-specification#4710

Open

Implement limits

4386c8c

trask force-pushed the complex-attrs-c-impl branch from f27638a to 4386c8c Compare November 18, 2025 22:27

jack-berg reviewed Nov 18, 2025

View reviewed changes

trask added 5 commits November 18, 2025 14:43

simplify putValue implementation

575535d

initialize array lists with correct size

f1ffad8

Add test for non-existent array type to improve code coverage

6480d0e

spotless

22e857d

Move warning to where users will see it

b91d3bb

iRevive mentioned this pull request Nov 22, 2025

OpenTelemetry spec: Extended Attribute typelevel/otel4s#1128

Open

jack-berg approved these changes Nov 24, 2025

View reviewed changes

trask added 5 commits November 24, 2025 20:01

Merge remote-tracking branch 'upstream/main' into complex-attrs-c-impl

59ab595

Don't allocate when already valid length

d44e727

Remove unnecessary suppress warnings

c6b9858

Remove test of deprecated feature

28fedf2

spotless

587e7e3

trask force-pushed the complex-attrs-c-impl branch from 88ecb20 to 587e7e3 Compare November 25, 2025 04:22

Don't call deprecated method

9b9ea16

jack-berg merged commit 7c5255f into open-telemetry:main Nov 25, 2025
27 of 28 checks passed

jack-berg mentioned this pull request Nov 26, 2025

Add generic Value#convert(Object) method #7076

Open

Complex attributes incubating implementation #7814

Complex attributes incubating implementation #7814

Uh oh!

Conversation

trask commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

jkwatson left a comment

Choose a reason for hiding this comment

Uh oh!

jack-berg commented Nov 17, 2025

Uh oh!

trask commented Nov 18, 2025

Uh oh!

trask commented Nov 18, 2025

Uh oh!

jack-berg commented Nov 18, 2025

Uh oh!

trask commented Nov 18, 2025

Uh oh!

jack-berg Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jack-berg Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

trask Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jack-berg Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

trask Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

trask Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

trask commented Nov 5, 2025 •

edited

Loading

codecov bot commented Nov 6, 2025 •

edited

Loading