-
Notifications
You must be signed in to change notification settings - Fork 891
Add setMeterConfigurator
support to MeterProvider
#7346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I need to add a bunch more tests, I just wanted to check in to see if the approach is sound. The idea is to have a sort of |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7346 +/- ##
============================================
+ Coverage 89.87% 89.89% +0.01%
- Complexity 6899 6917 +18
============================================
Files 786 786
Lines 20793 20833 +40
Branches 2026 2031 +5
============================================
+ Hits 18687 18727 +40
+ Misses 1465 1462 -3
- Partials 641 644 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...c/main/java/io/opentelemetry/sdk/metrics/internal/state/DefaultSynchronousMetricStorage.java
Outdated
Show resolved
Hide resolved
…l/state/DefaultSynchronousMetricStorage.java
Hi @jack-berg, any comments on this? I think it's ready for a first round of review |
Hey @fandreuz - sorry for the delay. I'm swamped with internal stuff right now. Trying to get in a spot to be able to spend more time doing code reviews for otel next week. |
...c/main/java/io/opentelemetry/sdk/metrics/internal/state/DefaultSynchronousMetricStorage.java
Outdated
Show resolved
Hide resolved
…l/state/DefaultSynchronousMetricStorage.java
Fixes #7051