-
Notifications
You must be signed in to change notification settings - Fork 891
Allow frameworks to add instrumentation scope conditions #7312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow frameworks to add instrumentation scope conditions #7312
Conversation
@brunobat is there any corresponding incubating or internal API that needs to be deprecated (or was this never exposed at all)? is test coverage already complete for the feature? (also, it looks like you need to run |
Moved to draft.
|
thanks, I support stabilizing this feature |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7312 +/- ##
=========================================
Coverage 90.03% 90.03%
Complexity 6915 6915
=========================================
Files 787 787
Lines 20864 20864
Branches 2023 2023
=========================================
Hits 18784 18784
Misses 1441 1441
Partials 639 639 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Stabilizing this is blocked by the spec. This feature is still "in development" at the spec level: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#tracerconfigurator |
These are available for experimental use via Sdk{Signal}ProviderUtil, e.g. https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/internal/SdkTracerProviderUtil.java#L43-L74 |
thanks, I got mixed up thinking this was about stabilizing instrumentation scope attributes 🙈 |
@jack-berg, I guess I need to ask in the spec meeting about the status of the feature you mention. |
@brunobat go ahead and open a spec issue about stabilizing it, e.g. https://github.com/open-telemetry/opentelemetry-specification/issues?q=is%3Aissue%20state%3Aclosed%20stabilize%20in%3Atitle |
I know the feature is internal, but it's there for 1y now and should be mature enough to be used.