fix: EBPF_NET_CRASH_METRIC_PORT container env in EBPF chart not being quoted issue. #1347
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
…sue. Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
|
Hi @nicolastakashi would it be okay if you take a look at this pr when you got chance? |
|
Hi @TylerHelmuth could you take a look this PR ? it's related to containers' env EBPF_NET_CRASH_METRIC_PORT in EBPF chart are not quoted, which will lead eBPF installation failure #1348 |
| @@ -10,4 +10,4 @@ log: | |||
| debug: | |||
| enabled: true | |||
| storeMinidump: true | |||
| sendUnplannedExitMetric: false | |||
There was a problem hiding this comment.
Should we revert it?
|
@hyfj44255 minor comment, besides that LGTM |
Hi@nicolastakashi thank you so much for your reivew, IMHO, we might want to set it to true since we can test out whether containers' env EBPF_NET_CRASHL_METRIC_PORT has been quoted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the containers' EBPF_NET_CRASH_METRIC_PORT env in EBPF chart are not quoted, which will lead EBPF installation failure
Fixes # (issue)
#1348
Type of change
How Has This Been Tested?
Go to repo root directory.
cd opentelemetry-helm-chartsCreate a kind cluster same as the one in repo's Github action
kind create cluster --name ebpf-cluster --config ./.github/kind-1.24.yamlRun CT to preform the test
ct install --charts charts/opentelemetry-ebpf.