-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grant ebpf k8s collector job watching permission. #1346
Open
hyfj44255
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
fidelity-contributions:feature/grant-ebpf-k8s-collector-job-watching-permission
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: grant ebpf k8s collector job watching permission. #1346
hyfj44255
wants to merge
11
commits into
open-telemetry:main
from
fidelity-contributions:feature/grant-ebpf-k8s-collector-job-watching-permission
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
…sue. Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
…s-collector-job-watching-permission Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Hi @TylerHelmuth could you take a look this PR when you get chance ,it's related to adjust the helm chart according to the change of Opentelemetry eBPF. #1349. BTW the I'm working on fixing the CI failure |
kayhern
force-pushed
the
feature/grant-ebpf-k8s-collector-job-watching-permission
branch
from
September 20, 2024 13:28
3a1734b
to
323ff85
Compare
Hi @TylerHelmuth the previous lint -test issue was fixed would it be okay if you help trigger the lint-test again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opentelemetry-network added k8s collector handle pods owned by a CronJob feature so we need to grant EBPF k8s collector job watching permission in k8s-collector-clusterrole.
Fixes # (issue)
#1349
Type of change
How Has This Been Tested?
Go to open-telemetry-opentelemetry-helm-chartsrepo root directory.
cd opentelemetry-helm-charts
Create a kind cluster same as the one in repo's Github action
kind create cluster --name ebpf-cluster --config ./.github/kind-1.24.yaml
Go to EBPF chart
cd charts/opentelemetry-ebpf
Run helm install to install the EBPF chart
helm install ebpf-chart-test . -f ci/requests-limits-values.yaml -n ebpf-chart-test
Run command to get ebpf k8s collector container - k8s-watcher's log, and search 'jobs.batch is forbidden' , if not able to search any error related to "not able to list job" means this PR's changing is working